Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed aira-current in breadcrumb #18155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Nov 25, 2024

Closes #18113

Added the aria-current to the span tag that it is generated in the DOM

Testing / Reviewing

  • Open Breadcrumb With Overflow Menu stories and turn on the VO.
  • You should hear "Breadcrumb 6, current item"

Screenshot 2024-11-25 at 14 10 15

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 8a596f0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6758ae19480e86000818bfbb
😎 Deploy Preview https://deploy-preview-18155--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8a596f0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6758ae19d33af100086fea21
😎 Deploy Preview https://deploy-preview-18155--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 8a596f0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6758ae19418d040008da6fa5
😎 Deploy Preview https://deploy-preview-18155--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.15%. Comparing base (a022b9a) to head (8a596f0).

Files with missing lines Patch % Lines
...react/src/components/Breadcrumb/BreadcrumbItem.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18155      +/-   ##
==========================================
- Coverage   84.16%   84.15%   -0.01%     
==========================================
  Files         404      404              
  Lines       14350    14351       +1     
  Branches     4619     4620       +1     
==========================================
  Hits        12077    12077              
- Misses       2111     2112       +1     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam
Copy link
Member

kennylam commented Dec 4, 2024

Hm, I'm unable to focus on text elements no matter the screen reader used (MacOS/iOS VoiceOver, JAWS).

@guidari
Copy link
Contributor Author

guidari commented Dec 4, 2024

Hm, I'm unable to focus on text elements no matter the screen reader used (MacOS/iOS VoiceOver, JAWS).

@kennylam
Yeah! You can't use tabs on the Breadcrumb that has the aria-current. You should use arrow navigation and you can hear the VO announcing the aria-current. The active one should not get focused with TAB navigation.

@kennylam
Copy link
Member

kennylam commented Dec 4, 2024

You should use arrow navigation and you can hear the VO announcing the aria-current.

But mobile users would not be able to navigate this way, right?

@guidari
Copy link
Contributor Author

guidari commented Dec 4, 2024

Good question Kenny, I'm not sure. I know it does not receive focus because it should not be a link.

We have this guidelines on our website.

https://carbondesignsystem.com/components/breadcrumb/accessibility/#keyboard-interactions

Screenshot 2024-12-04 at 12 31 07

@kennylam
Copy link
Member

kennylam commented Dec 5, 2024

Maybe we can check with Ragu, otherwise this looks fine to me.

@guidari
Copy link
Contributor Author

guidari commented Dec 9, 2024

Here on W3C says that it should still be an interactive element. Maybe we should change our specs. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: Breadcrumbs don't inform screen reader about current page
3 participants