-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed aira-current in breadcrumb #18155
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18155 +/- ##
==========================================
- Coverage 84.16% 84.15% -0.01%
==========================================
Files 404 404
Lines 14350 14351 +1
Branches 4619 4620 +1
==========================================
Hits 12077 12077
- Misses 2111 2112 +1
Partials 162 162 ☔ View full report in Codecov by Sentry. |
Hm, I'm unable to focus on text elements no matter the screen reader used (MacOS/iOS VoiceOver, JAWS). |
@kennylam |
But mobile users would not be able to navigate this way, right? |
Good question Kenny, I'm not sure. I know it does not receive focus because it should not be a link. We have this guidelines on our website. https://carbondesignsystem.com/components/breadcrumb/accessibility/#keyboard-interactions |
Maybe we can check with Ragu, otherwise this looks fine to me. |
Here on W3C says that it should still be an interactive element. Maybe we should change our specs. 🤔 |
Closes #18113
Added the
aria-current
to thespan
tag that it is generated in the DOMTesting / Reviewing