Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage for multiselect component #18146

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

soumyaraju
Copy link
Contributor

Closes #17480

Added test cases for improving code coverage of multiselect

@soumyaraju soumyaraju requested a review from a team as a code owner November 25, 2024 05:34
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c0d6ccd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6745d7970fa4140008a8b508
😎 Deploy Preview https://deploy-preview-18146--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c0d6ccd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6745d797a39e8c0008138d30
😎 Deploy Preview https://deploy-preview-18146--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 17250c2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67440c502d27200008fe70a1
😎 Deploy Preview https://deploy-preview-18146--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c0d6ccd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6745d7971df0c20008c637f6
😎 Deploy Preview https://deploy-preview-18146--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (f2ba3fd) to head (ea5d29c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18146      +/-   ##
==========================================
+ Coverage   83.22%   83.26%   +0.04%     
==========================================
  Files         404      404              
  Lines       14338    14338              
  Branches     4645     4645              
==========================================
+ Hits        11933    11939       +6     
+ Misses       2243     2237       -6     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gururajj77
Copy link
Contributor

Hi @soumyaraju , if possible could you please write more tests??

@soumyaraju
Copy link
Contributor Author

Hi @Gururajj77, i have added few more tests, could you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase MultiSelect unit test coverage
2 participants