Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid and column to web components - proposal #18034

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

lee-chase
Copy link
Member

@lee-chase lee-chase commented Nov 11, 2024

Closes #17909

An initial attempt at producing grid and column web components.

NOTE: It is not feature complete, but is intended as a functional first pass.

NOTE 2: It is possible not to use a context but this means having to hand wire sub-grid mode.

Changelog

New

  • Web components grid, column, column-hang and stories.

Testing / Reviewing

All stories to match React storybook

@lee-chase lee-chase requested a review from a team as a code owner November 11, 2024 11:02
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b487e81
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6746072bff52f10008a1ffa0
😎 Deploy Preview https://deploy-preview-18034--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b487e81
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6746072b166bd50008116fa3
😎 Deploy Preview https://deploy-preview-18034--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b487e81
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6746072b2838c900082ddf45
😎 Deploy Preview https://deploy-preview-18034--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lee-chase
Copy link
Member Author

I think I over estimated what subgrid is and used a context to pass narrow and condensed down. Didn’t realise until I got to the mixed gutters story.

It may be possible to refactor away the sub-grid component, needs a bit more thought.

Note w.r.t. context. If not permitted then I am unsure how to detect parent grid.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.22%. Comparing base (626289a) to head (c82b68d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18034      +/-   ##
==========================================
+ Coverage   82.87%   83.22%   +0.35%     
==========================================
  Files         404      404              
  Lines       14338    14338              
  Branches     4591     4645      +54     
==========================================
+ Hits        11882    11933      +51     
+ Misses       2296     2243      -53     
- Partials      160      162       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Carbon columns are cumbersome to write out long hand e.g. for web components
1 participant