-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grid and column to web components - proposal #18034
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think I over estimated what subgrid is and used a context to pass narrow and condensed down. Didn’t realise until I got to the mixed gutters story. It may be possible to refactor away the sub-grid component, needs a bit more thought. Note w.r.t. context. If not permitted then I am unsure how to detect parent grid. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18034 +/- ##
==========================================
+ Coverage 82.87% 83.22% +0.35%
==========================================
Files 404 404
Lines 14338 14338
Branches 4591 4645 +54
==========================================
+ Hits 11882 11933 +51
+ Misses 2296 2243 -53
- Partials 160 162 +2 ☔ View full report in Codecov by Sentry. |
Closes #17909
An initial attempt at producing grid and column web components.
NOTE: It is not feature complete, but is intended as a functional first pass.
NOTE 2: It is possible not to use a context but this means having to hand wire sub-grid mode.
Changelog
New
Testing / Reviewing
All stories to match React storybook