Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Implement codemod to rename slug prop to aiLabel for IBM Products components #17966

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sangeethababu9223
Copy link
Member

@sangeethababu9223 sangeethababu9223 commented Nov 5, 2024

Closes 6307

This PR updates the @carbon/upgrade package with a new transform ibm-products-slug-to-ailabel-prop, to update the slug prop in ibm products components Tearsheet, SidePanel, ExpressiveCard and ProductiveCard to AILabel .

Changelog

New

  • New transform file packages/upgrade/transforms/ibm-products-slug-to-ailabel-prop.js
  • Include fixtures in the packages/upgrade/transforms/__testfixtures__/ibm-products-slug-to-ailabel-prop.input.js and packages/upgrade/transforms/__testfixtures__/ibm-products-slug-to-ailabel-prop.output.js files
  • Include tests in packages/upgrade/transforms/__tests__/ibm-products-slug-to-ailabel-prop-test.js

Changed

  • Update packages/upgrade/src/upgrades.js with a new migration entry ibm-products-slug-to-ailabel-prop

Testing / Reviewing

  • Pulling down this PR
  • Run cd packages/upgrade
  • Run yarn build to build the CLI
  • Run ./bin/carbon-upgrade.js migrate list and verify a new entry ibm-products-slug-to-ailabel-prop present
  • Run npx jest transforms/__tests__/ibm-products-slug-to-ailabel-prop-test.js and verify test result

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 474ff6c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/672c440d0bbc000008a677b3
😎 Deploy Preview https://deploy-preview-17966--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 257a327
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6729fff0e20de60008dae5df
😎 Deploy Preview https://deploy-preview-17966--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 257a327
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6729fff09d67fd0008f049e6
😎 Deploy Preview https://deploy-preview-17966--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 474ff6c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672c440d9b79060008a3a159
😎 Deploy Preview https://deploy-preview-17966--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 474ff6c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672c440dce7d5c0008c84f1f
😎 Deploy Preview https://deploy-preview-17966--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (cdc8db7) to head (474ff6c).

Files with missing lines Patch % Lines
packages/upgrade/src/upgrades.js 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17966      +/-   ##
==========================================
- Coverage   81.82%   81.78%   -0.04%     
==========================================
  Files         404      404              
  Lines       14067    14073       +6     
  Branches     4360     4363       +3     
==========================================
  Hits        11510    11510              
- Misses       2395     2400       +5     
- Partials      162      163       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review November 6, 2024 07:06
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner November 6, 2024 07:06
@sangeethababu9223 sangeethababu9223 marked this pull request as draft November 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codemod to tranform slug to AILabel
1 participant