Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): close issues with no reproduction #17910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frankharkins
Copy link
Contributor

@frankharkins frankharkins commented Oct 29, 2024

Part of #13138, specifically:

Triage automation: Auto close issues that have needs reproduction label for x days (7 days ?)

Implementation

There's no easy way to work out when a label was applied from the GitHub API. Instead, we just check for issues with the status: needs reproduction label that haven't been updated at all in the last X days.

This action would currently close the following two issues, but may apply to more if you start automatically adding the "need reproduction" label to new issues.

ID      TITLE                                                                          LABELS                                                              UPDATED           
#17321  [Bug]: Problems when update from carbon-components to @Carbon/react            type: bug 🐛, status: needs triage 🕵️, status: needs reproduction    about 27 days ago
#16083  [a11y]: SideNavMenuItem is not keyboard operable, unable to focus using tab    type: a11y ♿, status: needs reproduction                            about 2 months ago

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 96d2177
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67212e4331d81e00081663fb
😎 Deploy Preview https://deploy-preview-17910--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 96d2177
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67212e425d16fe000837fba0
😎 Deploy Preview https://deploy-preview-17910--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 96d2177
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67212e42ab52c60008b06df4
😎 Deploy Preview https://deploy-preview-17910--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (6dc14bd) to head (96d2177).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17910   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         406      406           
  Lines       14046    14046           
  Branches     4403     4403           
=======================================
  Hits        11400    11400           
- Misses       2479     2480    +1     
+ Partials      167      166    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankharkins frankharkins changed the title ci(actions): add action to close stale issues ci(actions): close issues with no reproduction Oct 29, 2024
@frankharkins frankharkins marked this pull request as ready for review October 29, 2024 18:51
@frankharkins frankharkins requested a review from a team as a code owner October 29, 2024 18:51
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this! My only hesitation with this idea is it would probably end up closing issues that shouldn't be closed. Something like this is very likely:

  1. The issue receives the label
  2. They provide a repro link
  3. We miss it and/or we forget to remove the label
  4. Issue is closed when it shouldn't have

One way around that problem could be to parse all the issue body and comments when an issue is commented/updated/etc. to determine if a link to stackblitz or codesandbox exists.

Another way would be to turn off the issue closing and then we could manually as a team review issues with both the "needs repro" and "stale" labels to close them if needed.

The goal isn't to close issues anyway, it's to prompt a response with a reproduction. I think the second option is maybe the route to go.

Additionally

  • Remove the other label triggers so it's just the repro one
  • Update stale issue message

    This issue has been marked as stale because it needs a reproduction link. When you get the chance, use a sandbox template to reproduce the problem and post the link back here.

  • Remove the close issue message and the days-before-close (or whatever needs done to turn issue closing off)
  • Remove the debug-only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants