-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(actions): close issues with no reproduction #17910
base: main
Are you sure you want to change the base?
ci(actions): close issues with no reproduction #17910
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17910 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 406 406
Lines 14046 14046
Branches 4403 4403
=======================================
Hits 11400 11400
- Misses 2479 2480 +1
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. |
52100b9
to
30042ef
Compare
30042ef
to
96d2177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this! My only hesitation with this idea is it would probably end up closing issues that shouldn't be closed. Something like this is very likely:
- The issue receives the label
- They provide a repro link
- We miss it and/or we forget to remove the label
- Issue is closed when it shouldn't have
One way around that problem could be to parse all the issue body and comments when an issue is commented/updated/etc. to determine if a link to stackblitz or codesandbox exists.
Another way would be to turn off the issue closing and then we could manually as a team review issues with both the "needs repro" and "stale" labels to close them if needed.
The goal isn't to close issues anyway, it's to prompt a response with a reproduction. I think the second option is maybe the route to go.
Additionally
- Remove the other label triggers so it's just the repro one
- Update stale issue message
This issue has been marked as stale because it needs a reproduction link. When you get the chance, use a sandbox template to reproduce the problem and post the link back here.
- Remove the close issue message and the days-before-close (or whatever needs done to turn issue closing off)
- Remove the
debug-only
Part of #13138, specifically:
Implementation
There's no easy way to work out when a label was applied from the GitHub API. Instead, we just check for issues with the
status: needs reproduction
label that haven't been updated at all in the last X days.This action would currently close the following two issues, but may apply to more if you start automatically adding the "need reproduction" label to new issues.