Skip to content

Conversation

@patel1643
Copy link

@patel1643 patel1643 commented Jan 23, 2026

Closes # MASISMIG-68987

Summary

  • Updated the @carbon/react version to accommodate new changes/bug fix for FileUploader component

Change List (commits, features, bugs, etc)

  • package.json

Acceptance Test (how to verify the PR)

  • It can be tested by adding maxFileSize prop (this prop accepts number in bytes so for example: maxFileSize={100} means maximum acceptable size should be 100 bytes) to the FileUploader component and when a file is uploaded that's higher than 100bytes it would result in an error popup.

Regression Test (how to make sure this PR doesn't break old functionality)

  • Ensure the other components are still working as expected

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

Copy link
Collaborator

@hectordavis hectordavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can merge this once the workflows pass

@hectordavis hectordavis merged commit 60a62ca into carbon-design-system:4.x.x Jan 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants