[WIP] Require serialization/deserialization functions for custom scalars #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for grats ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
captbaritone
commented
Dec 30, 2023
| const abs = resolveRelativePath(module); | ||
| const relative = stripExt( | ||
| path.relative(path.dirname(this._destination), abs), | ||
| ); |
There was a problem hiding this comment.
TODO: Extract this so it can be shared
captbaritone
commented
Dec 30, 2023
| ), | ||
| name, | ||
| ); | ||
| if (name === "serialize") { |
There was a problem hiding this comment.
TODO: Comment explaining why we do this
captbaritone
commented
Dec 30, 2023
| @@ -769,7 +921,7 @@ class Codegen { | |||
| } | |||
|
|
|||
| function fieldDirective( | |||
| @@ -18,10 +18,21 @@ type SomeType { | |||
| hello: String | |||
| } | |||
|
|
|||
| scalar MyUrl | |||
| scalar MyUrl @exported(tsModulePath: "grats/src/tests/fixtures/custom_scalars/DefineCustomScalar.ts", functionName: "MyUrl", argCount: 0) | |||
There was a problem hiding this comment.
TODO: Rename functionName to something more generic.
TODO: Make argCount optional?
| ----------------- | ||
| { | ||
| "data": { | ||
| "echo": null, // TODO: That's not write |
There was a problem hiding this comment.
TODO: Look into these todos
| @@ -196,7 +196,7 @@ const testDirs = [ | |||
|
|
|||
| const schemaModule = await import(schemaPath); | |||
|
|
|||
| const actualSchema = schemaModule.getSchema(); | |||
| const actualSchema = schemaModule.getSchema(server.config); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
TODO