Add ARC auto-sync architecture #2570
Conversation
github-actions
bot
added
python
|
@Rot127, fuzzing, as I expected, shows that those instructions that are not yet supported for ARC in llvm lead to incorrect decoding and program crash. llvm-mc from the official github also fails with an error. Should we do something now or ignore it until llvm updates? |
|
You can fix it in our fork of LLVM. And open an issue in LLVM with a reference to the fix commit. They can cherry-pick it. If you have the time, you can also open a PR with the fix yourself. |
|
The problem is solved now. The DecodeGPR32RegisterClass return value was not checked (in llvm disassembler also) |
R33v0LT
force-pushed
the
auto-sync-arc
branch
from
aa93895 to
e2fb2d7
Compare
R33v0LT
force-pushed
the
auto-sync-arc
branch
from
e2fb2d7 to
06afa37
Compare
|
Do you consider this done? Then I would review it this week. |
Yes. I think it is done now |
There was a problem hiding this comment.
This was a very straight forward review! Excellent job, well done!
Please add ARC in cs_v6_release_guide.md und New features.
Simple two liner is enough. Just please mention about the memory operands.
Otherwise, please address the other small requests.
Regarding the not yet implemented memory operand type: Do you want to add them? It complicates the details a bit. But on the other hand there seems only the MemOperandRI type. So not too much work I think? Or was there another problem?
Nonetheless, we can merge it like this. But we should have them before v6 Gold.
cc @XVilka @kabeor
include/capstone/arc.h
Outdated
| ARC_INS_ADD_, | ||
| ARC_INS_ADD_F, | ||
| ARC_INS_ADD, | ||
| ARC_INS_AND_, |
There was a problem hiding this comment.
Please don't forget about those ones.
There was a problem hiding this comment.
Created pull request for this to capstone-llvm: capstone-engine/llvm-capstone#72
suite/auto-sync/src/autosync/cpptranslator/patches/BadConditionCode.py
Outdated
Show resolved
Hide resolved
suite/auto-sync/src/autosync/cpptranslator/patches/BadConditionCode.py
Outdated
Show resolved
Hide resolved
Your checklist for this pull request
Detailed description
This PR adds support for the ARC architecture in capstone. It is worth noting that this architecture is experimental in lvm, that is, full support for all instructions is not fully implemented. Also, MC tests in llvm (like llvm_root/llvm/test/MC/Disassembler/ARC/ldst.txt ) have a format different from other architectures, which is why tests auto-generated by MCUpdater.py does not add instruction bytes to yaml. I think this format will change when ARC is fully supported
To successfully pass the autosync test, a merge of the following PR is required: capstone-engine/llvm-capstone#69
Test plan
There are no differences in the way capstone is built with the ARC architecture
MC tests were generated by MCUpdater. Only instruction bytes are manually added. All other tests are added manually
At the moment, all tests are passing successfully, there are CI/CD results to confirm
Closing issues
None