Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cmake build arguments #2534

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Rename cmake build arguments #2534

wants to merge 1 commit into from

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Nov 4, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Rename build arguments for clearity:

  • BUILD_SHARED_LIBS -> CAPSTONE_BUILD_SHARED_LIBS
  • BUILD_STATIC_LIBS -> CAPSTONE_BUILD_STATIC_LIBS
  • BUILD_STATIC_LIBS -> CAPSTONE_BUILD_STATIC_MSVC_RUNTIME

Test plan

All green

Closing issues

...

@github-actions github-actions bot added python bindings Documentation Github-files Github related files labels Nov 4, 2024
@kabeor
Copy link
Member

kabeor commented Nov 5, 2024

CI failed.

@Rot127
Rename build arguments:
7e29045 
- BUILD_SHARED_LIBS -> CAPSTONE_BUILD_SHARED_LIBS
- BUILD_STATIC_LIBS -> CAPSTONE_BUILD_STATIC_LIBS
- BUILD_STATIC_LIBS -> CAPSTONE_BUILD_STATIC_MSVC_RUNTIME
@Rot127 Rot127 mentioned this pull request Nov 6, 2024
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation Github-files Github related files python bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rot127 @kabeor