Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LangflowAI #1183

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added LangflowAI #1183

wants to merge 3 commits into from

Conversation

AdamDudley
Copy link
Contributor

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • [ ☑️ ] I have tested the template using the method described in README.md thoroughly
  • [ ☑️ ] I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • [ ☑️ ] I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • [☑️ ] I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • [ ☑️ ] Icon is added as a png file to the logos directory.
  • [☑️ ] I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • [ ☑️ ] I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome app! Thanks!

description: Port on which the LangFlow server will run.
validRegex: /^\d+$/
- id: $$cap_langflow_database_url
label: PostgreSQL Database URL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include postgres as a service in this template. One click apps are meant to be truly one click as we should try to keep all the dependencies in the same template.

defaultValue: $$cap_gen_random_hex(32)
description: Secret key used to encrypt sensitive data.
validRegex: /.{32,}/
- id: $$cap_langflow_port
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really need to be a variable, let's fix it to 7860. Since it's not mapped and it's internal to the container, it's totally fine to keep it as a fixed value.

LANGFLOW_AUTO_LOGIN: $$cap_langflow_auto_login
LANGFLOW_BACKEND_ONLY: $$cap_langflow_backend_only
LANGFLOW_DEV: $$cap_langflow_dev
LANGFLOW_OPEN_BROWSER: $$cap_langflow_open_browser
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since could be hardcoded to false. Since it's run in a container, it won't launch the browser anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good point. I'll update that in a little while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants