Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add whisper as a webservice #1166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LiquidITGuy
Copy link
Contributor

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

- $$cap_appname-data:/var/lib/postgresql/data
restart: always
environment:
POSTGRES_USER: $$cap_pg_user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cap_pg_user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad I keep this during my test I'll fix it

volumes:
- $$cap_appname-data:/var/lib/postgresql/data
restart: always
environment:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these needed?

ASR_MODEL=base -e ASR_ENGINE=openai_whisper

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it work without but yes It's better with those
sorry this pr has been open too fast

public/v4/apps/whisper-asr-webservice.yml Outdated Show resolved Hide resolved
public/v4/apps/whisper-asr-webservice.yml Show resolved Hide resolved
public/v4/apps/whisper-asr-webservice.yml Show resolved Hide resolved
better description

Co-authored-by: Kasra Bigdeli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants