Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goaccess fixes for report modal #180

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

dshook
Copy link
Contributor

@dshook dshook commented Jan 5, 2025

Couple small fixes on the frontend to improve the report modal:

  • Update the title to be consistent with the button text
  • Hide the menu inside the modal that allows users to navigate to different panes within the report but actually breaks and navigates to the caprover dashboard inside the iframe

First of all, thank you for your contribution! 😄

Please make sure you have read contribution guidelines.

Most important items

  • Make sure to communicate your proposed changes ob our Slack channel beforehand.
  • Large PRs (50+ lines of code) will get rejected due to increased difficulty for review - unless they have been communicated beforehand with project maintainers.
  • Refactoring work will get rejected unless it's been communicated with project's maintainers beforehand. There is a thousand ways to write the same code. Every time a code is changed, there is a potential for a new bug. We don't want to refactor the code just for the sake of refactoring.

These rules are strictly enforced to make sure that we can maintain the project moving forward.

.getGoAccessReport(reportUrl)
.then((report: string) => {
// Add a couple extra override styles to the report to disable the hamburger menu that contains
// links which will result in navigating to the caprover dashboard within the iframe
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@githubsaturn githubsaturn merged commit 3f2bb36 into caprover:master Jan 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants