Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language localization support #141

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

CaryTrivett
Copy link
Contributor

@CaryTrivett CaryTrivett commented Jan 24, 2024

#140

First of all, thank you for your contribution! 😄

Please make sure you have read contribution guidelines.

Most important items

  • Make sure to communicate your proposed changes ob our Slack channel beforehand.
  • Large PRs (50+ lines of code) will get rejected due to increased difficulty for review - unless they have been communicated beforehand with project maintainers.
  • Refactoring work will get rejected unless it's been communicated with project's maintainers beforehand. There is a thousand ways to write the same code. Every time a code is changed, there is a potential for a new bug. We don't want to refactor the code just for the sake of refactoring.

These rules are strictly enforced to make sure that we can maintain the project moving forward.

@githubsaturn
Copy link
Collaborator

This is one of the best PRs that was pulled into this project! Thank you!

@githubsaturn githubsaturn merged commit d14d75c into caprover:master Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants