add numeric tests

capjamesg · Oct 18, 2024 · 92c0dcd · 92c0dcd
1 parent df1d416
commit 92c0dcd
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 3 deletions.
diff --git a/jamesql/index.py b/jamesql/index.py
@@ -870,8 +870,6 @@ def search(self, query: dict) -> List[str]:
 
                     document["_score"] = transformer.transform(tree)
 
-                    print(document["_score"])
-
                 results = sorted(results, key=lambda x: x.get("_score", 0), reverse=True)
 
             if query.get("skip"):
@@ -1254,7 +1252,7 @@ def _run(self, query: dict, query_field: str) -> List[str]:
 
                                 matching_highlights.update(matches_with_context)
                     else:
-                        for word in query_term.split(" "):
+                        for word in str(query_term).split(" "):
                             word = word.lower()
 
                             if gsi.get(word) is None:

diff --git a/tests/query_simplification.py b/tests/query_simplification.py
@@ -67,6 +67,13 @@ def create_indices(request):
             "",
             DoesNotRaise(),
         ),  # test negation simplification with empty string result
+        (
+            "100 100",
+            "100",
+            0,
+            "",
+            DoesNotRaise(),
+        ),  # test numeric query simplification
         (
             "screaming -sky",
             "screaming -sky",

diff --git a/tests/test.py b/tests/test.py
@@ -223,6 +223,36 @@ def create_indices(request):
             "tolerate it",
             DoesNotRaise(),
         ),  # test starts_with
+        (
+            {
+                "query": {"lyric": {"contains": "100"}},
+                "limit": 10,
+                "sort_by": "lyric"
+            },
+            0,
+            "",
+            DoesNotRaise(),
+        ),  # test numeric query
+        (
+            {
+                "query": {"lyric": {"contains": 100}},
+                "limit": 10,
+                "sort_by": "lyric"
+            },
+            0,
+            "",
+            DoesNotRaise(),
+        ),  # test numeric query cast as int
+        (
+            {
+                "query": {"lyric": {"contains": 100.001}},
+                "limit": 10,
+                "sort_by": "lyric"
+            },
+            0,
+            "",
+            DoesNotRaise(),
+        ),  # test numeric query cast as float
         (
             {
                 "query": {"lyric": {"starts_with": "started with"}},