Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-picker): add persistent ContentUrl functionality to pickFile on Android #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rbreckner
Copy link

Change reasons

I use the plugin in an app where usage of file picker and consumption of the returned path are not at the same moment. After restarting the app or rebooting the device, the path is invalidated on Android, while it works fine on iOS.

With the provided changes and my little understanding of native Android code, in pickFile(...) it is possible to optionally use a different Intent which grants persistence permission, which will be taken later inside the activity callback.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

@robingenz
Copy link
Member

Thank you for your PR. I am currently planning to make a complete rewrite of the plugin. For this reason I would like to leave your PR open. However, I keep this issue in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants