Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live-updates): add getCurrentBundle() and getNextBundle() method #252

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robingenz
Copy link
Member

@robingenz robingenz commented Aug 9, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #225

@robingenz robingenz self-assigned this Aug 9, 2024
@tbence94
Copy link

tbence94 commented Oct 9, 2024

Could this getNextBundle() call help me decide if there is a newer version before calling sync() to actually download it?
I would like to show some loading/updating screen to the user if there is a bundle being downloaded in the background when running sync.

I couldn't find a way to do this with the current API, because sync is the only option to check for new updates, but it also downloads it immediately.

@robingenz
Copy link
Member Author

@tbence94 No, i guess you are looking for this issue: #263

@tbence94
Copy link

I think #311 fetchLatestBundle and the example:

const isNewBundleAvailable = async () => {
  const { bundleId: latestBundleId } = await LiveUpdate.fetchLatestBundle();
  if (latestBundleId) {
    const { bundleId: currentBundleId } = await LiveUpdate.getBundle();
    return latestBundleId !== currentBundleId;
  } else {
    return false;
  }
};

can be used for showing update screen until #263 gets implemented. 👍
It might not show the actual progress of the download, but it will be better then showing nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(live-updates): add getCurrentBundle() and getNextBundle() method
2 participants