Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmpls - Remote Service & Messaging #40

Merged
merged 4 commits into from
Feb 14, 2024
Merged

xmpls - Remote Service & Messaging #40

merged 4 commits into from
Feb 14, 2024

Conversation

navinkrishnan
Copy link
Contributor

  • Remote Service
  • Messaging

@navinkrishnan
xmpls
35d1963 
* Remote Service
* Messaging
@navinkrishnan
Copy link
Contributor Author

Copy contents to run remote service and messaging in incidents-app

@navinkrishnan navinkrishnan changed the title xmpls xmpls - Remote Service & Messaging Jan 16, 2024
danjoa
danjoa reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@danjoa danjoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we walk through that in a meeting.

In that we should also check whether the incidents-app/xmpls approach is a best practice for such exercises including a lot of additions.

@navinkrishnan
revamp
a8ffe2c 
* Customer key ID to String
* CSV data changed
* clean up db cds from xmpls
* projections moved to new service RemoteService
@navinkrishnan
Copy link
Contributor Author

As per the discussion, following changes are done

  • Customer key field changed to string in main
  • Adapted csv file data for ID with String as it needed to match with BusinessPartner data in xmpls
  • removed db related files from xmpls
  • Moved BusinessPartner related projections to a new service named RemoteService

@danjoa @DanSchlachter Please review and let me know if any changes needed.

@DanSchlachter DanSchlachter merged commit e909e5d into main Feb 14, 2024
3 checks passed
@DanSchlachter DanSchlachter deleted the remote-svc-messaging branch February 14, 2024 13:13
@sjvans sjvans mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjoa danjoa danjoa left review comments

@DanSchlachter DanSchlachter DanSchlachter approved these changes

@CHERIANS CHERIANS Awaiting requested review from CHERIANS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navinkrishnan @DanSchlachter @danjoa