Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove prettier dependency #154

Merged
merged 1 commit into from
Feb 5, 2024
Merged

chore: Remove prettier dependency #154

merged 1 commit into from
Feb 5, 2024

Conversation

hm23
Copy link
Contributor

@hm23 hm23 commented Feb 5, 2024

Prettier dependency is not required, prettier scripts use npx.

@hm23 hm23 marked this pull request as ready for review February 5, 2024 12:59
@hm23 hm23 requested a review from a team as a code owner February 5, 2024 12:59
@schwma
Copy link
Member

schwma commented Feb 5, 2024

Could you please add npx prettier ... for the prettier and prettier:check scripts?

@hm23
Copy link
Contributor Author

hm23 commented Feb 5, 2024

Could you please add npx prettier ... for the prettier and prettier:check scripts?

This is already the case, or?

@schwma
Copy link
Member

schwma commented Feb 5, 2024

Oh sorry, I just saw that they already use npx!

@hm23 hm23 merged commit 85d2d97 into main Feb 5, 2024
3 checks passed
@hm23 hm23 deleted the remove-prettier-dependency branch February 5, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants