Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature rebrand IoT #14539

Merged
merged 38 commits into from
Dec 13, 2024
Merged

Feature rebrand IoT #14539

merged 38 commits into from
Dec 13, 2024

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Dec 4, 2024

Done

  • Feature branch for the IoT bubble rebrand

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-16362

@webteam-app
Copy link

@mtruj013 mtruj013 changed the title Feature rebrand iot Feature rebrand IoT Dec 4, 2024
britneywwc and others added 16 commits December 5, 2024 16:02
* Redesigned internet-of-things/management

* Applied design review

* Fix missing hr's on smaller screens (using vanilla patterns)

* Applied UX Review

* Use image module

* Fix line breaks + use hr for p-rule

* Removed unnecessary outer_content block

* Fixed line break

---------

Co-authored-by: Muhammad Ali <[email protected]>
…14545)

* Fix: not redirected to static contact-us page when javascript is disabled

* Redirect to success banner upon form submission

---------

Co-authored-by: Muhammad Ali <[email protected]>
* Redesigned internet-of-things/smart-city

* Accessible headings order

* Reduced padding for image with h5

* Applied UX Review

* Structural hierarchy cleanup

* Use image module

* Applied design review

* Applied code review

---------

Co-authored-by: Muhammad Ali <[email protected]>
* Redesigned iot/smart-home

* Applied design review

* Applied UX Review

* Applied code review

* Applied code review suggestions

---------

Co-authored-by: Muhammad Ali <[email protected]>
immortalcodes and others added 8 commits December 10, 2024 21:44
…t-of-things-gateways

WD-16643 Rebrand /internet-of-things/gateways
* Rebranded embedded page

* Quick fix: remove empty tag

* Applied UX Review

* Applied design review suggestions

* Added aria-labels on Learn more.* links

* Lazy load images not currently in viewport

* Added a shallow section around image (design suggestion)

---------

Co-authored-by: Muhammad Ali <[email protected]>
…age (#14555)

* Removed pagination from modal form and converted to single page

* Applied design review suggestion

---------

Co-authored-by: Muhammad Ali <[email protected]>
… single page (#14567)

* Removed pagination + conversion to single page

* Cleanup

---------

Co-authored-by: Muhammad Ali <[email protected]>
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muhammad-ali-pk muhammad-ali-pk merged commit 612c698 into main Dec 13, 2024
29 checks passed
@muhammad-ali-pk muhammad-ali-pk deleted the feature-rebrand-iot branch December 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants