-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature rebrand IoT #14539
Merged
Merged
Feature rebrand IoT #14539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: /internet-of-things/appstore redesgin
feat: /iot redesign
* Redesigned internet-of-things/management * Applied design review * Fix missing hr's on smaller screens (using vanilla patterns) * Applied UX Review * Use image module * Fix line breaks + use hr for p-rule * Removed unnecessary outer_content block * Fixed line break --------- Co-authored-by: Muhammad Ali <[email protected]>
…14545) * Fix: not redirected to static contact-us page when javascript is disabled * Redirect to success banner upon form submission --------- Co-authored-by: Muhammad Ali <[email protected]>
Co-authored-by: Muhammad Ali <[email protected]>
* Redesigned internet-of-things/smart-city * Accessible headings order * Reduced padding for image with h5 * Applied UX Review * Structural hierarchy cleanup * Use image module * Applied design review * Applied code review --------- Co-authored-by: Muhammad Ali <[email protected]>
* Redesigned iot/smart-home * Applied design review * Applied UX Review * Applied code review * Applied code review suggestions --------- Co-authored-by: Muhammad Ali <[email protected]>
…t-of-things-gateways WD-16643 Rebrand /internet-of-things/gateways
Rebrand /iot/smart-displays
* Rebranded embedded page * Quick fix: remove empty tag * Applied UX Review * Applied design review suggestions * Added aria-labels on Learn more.* links * Lazy load images not currently in viewport * Added a shallow section around image (design suggestion) --------- Co-authored-by: Muhammad Ali <[email protected]>
…age (#14555) * Removed pagination from modal form and converted to single page * Applied design review suggestion --------- Co-authored-by: Muhammad Ali <[email protected]>
… single page (#14567) * Removed pagination + conversion to single page * Cleanup --------- Co-authored-by: Muhammad Ali <[email protected]>
muhammad-ali-pk
added
Review: QA +1
Don't merge
and removed
Review: QA needed
Don't merge
labels
Dec 13, 2024
Co-authored-by: Muhammad Ali <[email protected]>
Co-authored-by: Muhammad Ali <[email protected]>
muhammad-ali-pk
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-16362