minor: cleaning up const and renaming variables

Author: mattkae

src/background_client.cpp

@@ -106,7 +106,7 @@ struct BackgroundClient::Self : egmde::FullscreenClient
 
     void render_text(uint32_t width, uint32_t height, unsigned char* buffer) const;
 
-    bool wallpaper_enabled;
+    bool const wallpaper_enabled;
     Colour const& wallpaper_top_colour;
     Colour const& wallpaper_bottom_colour;
     Colour const& crash_background_colour;
@@ -388,18 +388,9 @@ void BackgroundClient::Self::draw_screen(SurfaceInfo& info, bool draws_crash) co
     std::lock_guard lock{buffer_mutex};
 
     // Don't draw diagnostic background if file is empty or font not found
-    bool file_exists;
-    if (fs::exists(diagnostic_path.value_or("")))
-    {
-        file_exists = fs::file_size(diagnostic_path.value());
-    }
-    else
-    {
-        file_exists = false;
-    }
-
-    bool should_draw_crash = draws_crash && file_exists;
-    if (!wallpaper_enabled && !should_draw_crash)
+    bool const have_diagnostic = diagnostic_path && fs::exists(diagnostic_path.value()) && fs::file_size(diagnostic_path.value());
+    bool const should_show_diagnostic = draws_crash && have_diagnostic;
+    if (!wallpaper_enabled && !should_show_diagnostic)
     {
         return;
     }
@@ -445,7 +436,7 @@ void BackgroundClient::Self::draw_screen(SurfaceInfo& info, bool draws_crash) co
 
     auto buffer = static_cast<unsigned char*>(info.content_area);
 
-    if (should_draw_crash)
+    if (should_show_diagnostic)
     {
         render_background(width, height, buffer, crash_background_colour);
         render_text(width, height, buffer);