Untwisting logic

Author: mattkae

src/background_client.cpp

@@ -398,21 +398,10 @@ void BackgroundClient::Self::draw_screen(SurfaceInfo& info, bool draws_crash) co
         file_exists = false;
     }
 
-    if (!wallpaper_enabled)
+    bool should_draw_crash = draws_crash && file_exists;
+    if (!wallpaper_enabled && !should_draw_crash)
     {
-        if (draws_crash)
-        {
-            if (!file_exists)
-            {
-                // If we're drawing a crash but the diagnostic file doesn't
-                // exist, continue to not show the background.
-                return;
-            }
-        }
-        else
-        {
-            return;
-        }
+        return;
     }
 
     bool const rotated = info.output->transform & WL_OUTPUT_TRANSFORM_90;
@@ -456,7 +445,7 @@ void BackgroundClient::Self::draw_screen(SurfaceInfo& info, bool draws_crash) co
 
     auto buffer = static_cast<unsigned char*>(info.content_area);
 
-    if (draws_crash && file_exists)
+    if (should_draw_crash)
     {
         render_background(width, height, buffer, crash_background_colour);
         render_text(width, height, buffer);