Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad output with ssh keys in testflinger reserve command #425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

plars
Copy link
Collaborator

@plars plars commented Dec 6, 2024

Description

testflinger reserve command could generate improperly formatted yaml
this fixes that and also adds a test for it

Resolved issues

CERTTF-461
#422

Documentation

N/A

Web service API changes

N/A

Tests

Added a new unit test

@plars plars requested a review from a team December 6, 2024 20:53
@jocave jocave linked an issue Dec 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@jocave jocave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testflinger-cli reserve with arguments generates invalid job yaml file
3 participants