Add testflinger-testenv container #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plars
force-pushed
the
testflinger-testenv
branch
2 times, most recently
from
e57d60d to
ef47185
Compare
plars
force-pushed
the
testflinger-testenv
branch
6 times, most recently
from
bd09241 to
8d2d3ce
Compare
plars
force-pushed
the
testflinger-testenv
branch
from
8d2d3ce to
9165857
Compare
|
A few more changes:
|
nancyc12
previously approved these changes
Dec 13, 2024
| push: | ||
| branches: | ||
| - main | ||
| - testflinger-testenv |
There was a problem hiding this comment.
should we remove testflinger-testenv?
There was a problem hiding this comment.
you mean the commit that I literally called "WIP: remove this" so that I would remember to rebase and drop it before opening a PR? yes... yes I should remove that. blush thanks for catching that :)
plars
force-pushed
the
testflinger-testenv
branch
from
7f9e1b1 to
7c10bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the test phase for agents, we currently have it run under a docker image pulled from dockerhub at plars/testflinger-testenv-focal (don't be too bothered that it's focal based, it's just to give some working env on the agent-host and this one is well tested).
Now that we're on GH for everything, we should just use ghcr.io, so that nobody has to switch it over to a new location when that bus hits me some day :)
This is the first step in resolving this. I intentionally didn't change the path pointed to by the tf-test script that the agent calls yet, because we need to make sure firewall rules are all adjusted and everything before rolling this out in production.
Resolved issues
N/A
Documentation
There's a small README there just saying what it is, but this doesn't really do anything different, just moves the location
Web service API changes
N/A
Tests
Successful action run: https://github.com/canonical/testflinger/actions/runs/11961073449
Published container image: https://github.com/canonical/testflinger/pkgs/container/testflinger%2Ftestflinger-testenv
I also tried pulling this container image and running it locally.