-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restricted Queues #406
Restricted Queues #406
Conversation
88844df
to
65bbcc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor question, but I think once that's sorted then we can land this - then do some further testing in staging before deployment to production. There's some policy documentation that needs to be written, but I think that's more specific to our own policies of how we use it, so we'll need to sort out where that should go.
65bbcc8
to
1f693ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, let's land and do some further testing in staging.
Description
This PR adds restricted queue functionality to Testflinger. Restricted Queues are special queues that require authentication/authorization for job submission. A list of these queues are stored in a collection called
restricted_queues
. For every job submitted, the requested queue is checked to make sure it is not in the restricted queue collection. If it is, a JWT token must be submitted with the job with adequate permission to push to that restricted queue.Resolved issues
Resolves https://warthogs.atlassian.net/browse/CERTTF-419
Documentation
Documentation was added to the public documentation in docs/
Web service API changes
N/A
Tests
Unit tests were added - these tests as well as previous job_priority/authentication tests were moved to test_v1_authorization.py.