Add firmware_update phase support for HPE Gen10/Gen11/RL machines

device-connectors/src/testflinger_device_connectors/devices/__init__.py

@@ -29,6 +29,8 @@
 import testflinger_device_connectors
 from testflinger_device_connectors.fw_devices.firmware_update import (
     detect_device,
+    LVFSDevice,
+    FirmwareUpdateError,
 )
 
 logger = logging.getLogger(__name__)
@@ -150,32 +152,38 @@ def firmware_update(self, args):
         device_ip = config["device_ip"]
         target_device_username = "ubuntu"
         exitcode = 0
-        supported_version = ["latest"]
+        lvfs_supported_version = ["latest"]
 
-        if version not in supported_version:
-            logger.info(
-                "Fail to provide version in firmware_update_data. "
-                + "Current supported version: latest",
+        try:
+            target_device = detect_device(
+                device_ip, target_device_username, config
             )
-            exitcode = 1
-        else:
-            try:
-                target_device = detect_device(
-                    device_ip, target_device_username
+            # For LVFS, only update to latest is supported
+            if (
+                isinstance(target_device, LVFSDevice)
+                and version not in lvfs_supported_version
+            ):
+                raise FirmwareUpdateError(
+                    "Fail to provide version in firmware_update_data. "
+                    f"Current supported version: {lvfs_supported_version}"
                 )
-                target_device.get_fw_info()
-                if version == "latest":
-                    reboot_required = target_device.upgrade()
-                if reboot_required:
-                    target_device.reboot()
-                    update_succeeded = target_device.check_results()
-                    if not update_succeeded:
-                        exitcode = 1
-            except Exception as err:
-                logger.error("Firmware Update failed: ", str(err))
-                exitcode = 1
-            finally:
-                logger.info("END firmware_update")
+            target_device.get_fw_info()
+            reboot_required = (
+                target_device.upgrade()
+                if version == "latest"
+                else target_device.downgrade(version)
+            )
+            if reboot_required:
+                target_device.reboot()
+                if not target_device.check_results():
+                    raise FirmwareUpdateError(
+                        "The firmware version did not update successfully"
+                    )
+        except Exception as e:
+            logger.error("Firmware Update failed: ", str(e))
+            exitcode = 1
+        finally:
+            logger.info("END firmware_update")
         if ignore_failure:
             exitcode = 0
         return exitcode