Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building the arch-independent snap, don't pip install binaries #182

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

plars
Copy link
Collaborator

@plars plars commented Jan 2, 2024

Description

Adjust snapcraft.yaml to avoid installing binaries with pip for the arch-independent snap.

Resolved issues

Snap publication was previously failing in the new github action due to this error:

- found binaries for architecture 'all': lib/python3.10/site-packages/charset_normalizer/md.cpython-310-x86_64-linux-gnu.so, lib/python3.10/site-packages/charset_normalizer/md__mypyc.cpython-310-x86_64-linux-gnu.so, lib/python3.10/site-packages/yaml/_yaml.cpython-310-x86_64-linux-gnu.so

Basically we were pulling binaries for some things like cpython. However we don't really need those binaries for it to run correctly. We can prevent this through some extra pip options, which are now set in the build-environment section of the snapcraft yaml.

Documentation

n/a

Tests

I forced the action to run against this branch and the snap built and published - https://canonical.greenhouse.io/scorecards/75984869

@plars plars requested a review from a team January 2, 2024 17:04
Copy link
Collaborator

@jocave jocave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have to admit I didn't know there was such thing as an arch independent snap!

@plars plars merged commit 17c83c7 into main Jan 3, 2024
3 checks passed
@plars plars deleted the cli-snap-pip-no-binary-option branch January 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants