Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testflinger-cli reserve with arguments generates invalid job yaml file #422

Closed
jocave opened this issue Nov 29, 2024 · 1 comment · Fixed by #425
Closed

testflinger-cli reserve with arguments generates invalid job yaml file #422

jocave opened this issue Nov 29, 2024 · 1 comment · Fixed by #425
Assignees
@plars

Comments

@jocave
Copy link
Collaborator

jocave commented Nov 29, 2024

Example of the invocation that is accepted by the client but generates a yaml file that does not pass schema validation:

testflinger-cli  reserve --queue myqueue --image https://cdimage.ubuntu.com/ubuntu-server/noble/daily-preinstalled/current/noble-preinstalled-server-arm64+raspi.img.xz --key lp:joebloggs

Output:

Unexpected error status from testflinger server: [422] {"detail":{"json":{"_schema":["Invalid input type."]}},"message":"Validation error"}

It seems like the behaviour of this subcommand is not tested in https://github.com/canonical/testflinger/blob/main/cli/testflinger_cli/tests/test_cli.py
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CERTTF-461.

This message was autogenerated

@plars plars self-assigned this Dec 6, 2024
@plars plars mentioned this issue Dec 6, 2024
Merged
@jocave jocave linked a pull request Dec 9, 2024 that will close this issue
Fix bad output with ssh keys in testflinger reserve command #425
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plars plars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bad output with ssh keys in testflinger reserve command canonical/testflinger
2 participants
@plars @jocave