Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tag should query MAAS machines once #228

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: tag should query MAAS machines once #228

merged 1 commit into from
Aug 22, 2024

Conversation

skatsaounis
Copy link
Collaborator

  • Query MAAS machines only once to find system IDs of all user provided identifiers
  • Check that there is no machine being added more than once with the same or different identifier
  • Add simple acceptance test to confirm that maas_tag is working appropriately

Resolves GH: #175

@skatsaounis skatsaounis requested a review from troyanov July 30, 2024 11:34
@skatsaounis skatsaounis linked an issue Jul 30, 2024 that may be closed by this pull request
Updating tags gets slower and slower with more nodes. #175
Closed
@skatsaounis skatsaounis merged commit f5e4783 into canonical:master Aug 22, 2024
8 checks passed
@skatsaounis skatsaounis deleted the fix-tag-machines branch August 22, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyanov troyanov troyanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating tags gets slower and slower with more nodes.
2 participants
@skatsaounis @troyanov