Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E integration testing with headscale and derper #42

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Conversation

samuelallan72
Copy link
Collaborator

@samuelallan72 samuelallan72 commented Jan 8, 2025

@samuelallan72 samuelallan72 requested a review from a team as a code owner January 8, 2025 07:22
@samuelallan72 samuelallan72 marked this pull request as draft January 8, 2025 07:22
Copy link

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording change required.

docs/e2e-testing-headscale-derper-tailscale.md Outdated Show resolved Hide resolved
docs/e2e-testing-headscale-derper-tailscale.md Outdated Show resolved Hide resolved
docs/e2e-testing-headscale-derper-tailscale.md Outdated Show resolved Hide resolved
Pjack
Pjack previously approved these changes Jan 16, 2025
@samuelallan72 samuelallan72 marked this pull request as ready for review January 16, 2025 05:32
Pjack
Pjack previously approved these changes Jan 16, 2025
chanchiwai-ray
chanchiwai-ray previously approved these changes Jan 17, 2025
Copy link

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very comprehensive, but I don't have technical knowledge to provide a rigorous feedback. I do left one small comment about defining the terms.

Comment on lines +48 to +59
```text
Headscale -----> Derper (and Tailscale)
^
|
+------------+--------+
| | |
Internal-1 User-1 User-2
^ ^ ^
| | |
| +--------+
| |
Jumpbox-1 Jumpbox-2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great to define the terms (e.g. Jumpbox-1 ...) here, rather that mentioning them somewhere in the configuration / test case section. For example, the word jumpbox is only mentioned in line 261:

In this environment, this simulates a jumpbox machine within a locked down datacenter (for example), that users such as operators and admins need to access.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point. In this case, these are simply the VM hostnames. I can make that clearer. :)

@samuelallan72 samuelallan72 dismissed stale reviews from chanchiwai-ray and Pjack via 0f35113 January 17, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants