-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E integration testing with headscale and derper #42
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small wording change required.
This is so we can better test connectivity. internal-1 and internal-2 cannot communicate without tailscale, so if it works with tailscale, we can demonstrate tailscale working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very comprehensive, but I don't have technical knowledge to provide a rigorous feedback. I do left one small comment about defining the terms.
```text | ||
Headscale -----> Derper (and Tailscale) | ||
^ | ||
| | ||
+------------+--------+ | ||
| | | | ||
Internal-1 User-1 User-2 | ||
^ ^ ^ | ||
| | | | ||
| +--------+ | ||
| | | ||
Jumpbox-1 Jumpbox-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be great to define the terms (e.g. Jumpbox-1
...) here, rather that mentioning them somewhere in the configuration / test case section. For example, the word jumpbox is only mentioned in line 261:
In this environment, this simulates a jumpbox machine within a locked down datacenter (for example), that users such as operators and admins need to access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point. In this case, these are simply the VM hostnames. I can make that clearer. :)
0f35113
See https://github.com/canonical/tailscale-snap/blob/e2e/docs/e2e-testing-headscale-derper-tailscale.md for the rendered file.