Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix issues found in common.mk with charmcraft #289

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: fix issues found in common.mk with charmcraft #289

merged 1 commit into from
Dec 9, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Dec 6, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau requested a review from a team December 6, 2024 22:36
@lengau lengau force-pushed the work/CRAFT-3707/common.mk branch from 731b6fa to 0643c03 Compare December 6, 2024 22:50
@tigarmo tigarmo requested a review from a team December 9, 2024 11:42
@lengau lengau merged commit 0ffe5a7 into main Dec 9, 2024
11 checks passed
@lengau lengau deleted the work/CRAFT-3707/common.mk branch December 9, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @tigarmo @mr-cal