Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release notes index and template #286

Merged

Conversation

medubelko
Copy link
Contributor

@medubelko medubelko commented Nov 25, 2024

Release notes occupy their own top-level section in the documentation TOC.

The template for individual release notes is included as a comment at the end of the index. This follows a pattern set by our changelogs. If there's a better way of including copyable templates, please chime in!

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

CRAFT-3712

Release notes occupy their own top-level section in the documentation TOC.

The template for individual release notes is included as a comment at the end
of the index.
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

docs/release-notes/index.rst Outdated Show resolved Hide resolved
docs/release-notes/index.rst Outdated Show resolved Hide resolved
docs/release-notes/index.rst Outdated Show resolved Hide resolved
docs/release-notes/index.rst Outdated Show resolved Hide resolved
@medubelko
Copy link
Contributor Author

@mr-cal

Re: #286 (comment)

I'm hedging against future projects where we might elect not to do this. Should I make it required?

@mr-cal
Copy link
Contributor

mr-cal commented Nov 29, 2024

@mr-cal

Re: #286 (comment)

I'm hedging against future projects where we might elect not to do this. Should I make it required?

Elect not to do which part? The semantic versioning?

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

docs/release-notes/index.rst Show resolved Hide resolved
docs/release-notes/index.rst Outdated Show resolved Hide resolved
docs/release-notes/index.rst Show resolved Hide resolved
@medubelko
Copy link
Contributor Author

@mr-cal
Re: #286 (comment)
I'm hedging against future projects where we might elect not to do this. Should I make it required?

Elect not to do which part? The semantic versioning?

Elect to include the optional part about forward-porting.

@medubelko medubelko merged commit dfe2e9a into canonical:main Nov 29, 2024
8 of 11 checks passed
@medubelko medubelko deleted the craft-3650-release-notes-index-template branch November 29, 2024 17:53
@mr-cal
Copy link
Contributor

mr-cal commented Nov 29, 2024

Elect to include the optional part about forward-porting.

I'm happy with what you merged, no need to make it required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants