Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(HACKING): update commit message guidelines #162

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Dec 14, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Updates to commit message guidelines to be more descriptive and authoritative.

Preview RST here

@mr-cal mr-cal requested a review from lengau December 14, 2023 19:06
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d328c4) 100.00% compared to head (58777ac) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           10        10           
  Branches         2         2           
=========================================
  Hits            10        10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HACKING.rst Show resolved Hide resolved
HACKING.rst Show resolved Hide resolved
HACKING.rst Show resolved Hide resolved
HACKING.rst Outdated Show resolved Hide resolved
HACKING.rst Show resolved Hide resolved
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
Copy link
Contributor Author

mr-cal commented Dec 14, 2023

Should we add a merge type for PRs like this? canonical/craft-parts#612

@syu-w
Copy link
Contributor

syu-w commented Dec 14, 2023

That maybe chore? Since it self not include anything.

HACKING.rst Outdated Show resolved Hide resolved
HACKING.rst Outdated Show resolved Hide resolved
@mr-cal mr-cal requested review from syu-w and lengau December 15, 2023 17:21
HACKING.rst Show resolved Hide resolved
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent!

@mr-cal mr-cal merged commit 4b2c78e into main Dec 15, 2023
13 checks passed
@mr-cal mr-cal deleted the conventional-commit-documentation branch December 15, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants