-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tooling #126
Upgrade tooling #126
Conversation
97181a9
to
7314218
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Batalex ! Thank you for this chore work!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work publishing spark8t
in PyPi! The PR looks superb!
@deusebio, @theoctober19th thanks for the reviews! What are your thoughts on removing the unused elements I listed in the description? |
@Batalex I'm fine with updating / refactoring places where the code is not used / relevant anymore, (eg, unused exceptions, functions which can be replaced with simple inbuilt structures, etc.). One thing I'm not quite sure about is the purpose of the |
Align with our existing tooling in charms
925b632
to
cb5f203
Compare
Changes
We have some unused or outdated stuff that we could remove:
utils.py
union()
: we use it forPropertyFile
objects which are only one level data structure AFAICT. The|
operator is sufficient_check()
: used in one place infilter_none
, trivial to inline thismkdir()
create_dir_if_not_exists()
exceptions.py
K8sClusterNotReachable
services.py
InMemoryAccountRegistry
is only used in unit tests, maybe it could go there? We would not have to distribute it in the package