Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle create/edit subscriber when target DG does not exist #716

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Jan 23, 2025

Description

Network slices contain references to device groups. The webconsole allows you to create a NS with a reference to X Device Group before actually creating the Device Group. In this case, the DG will appear in the list of possible device groups to add a subscriber to.

If you try to add a subscriber to non-existent device group, the following errors will show up:

image

image

This PR handles the cases:

  1. Create a subscriber in a non-existent DG
  2. Edit a subscriber from a DG that no longer exists to some other DG
  3. Edit a subscriber that is not associated to any DG
  4. Edit a subscriber from some DG to a non-existing DG

If the target DG does not exist, the subscriber will not be created/edited and an error will be shown:

image

We can deal with the fact that the DG should not be shown in the first place here: #717

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@patriciareinoso patriciareinoso marked this pull request as ready for review January 24, 2025 10:52
@patriciareinoso patriciareinoso requested a review from a team as a code owner January 24, 2025 10:52
@patriciareinoso patriciareinoso changed the title fix: handle case in which DG does not exist fix: handle create/edit subscriber when target DG does not exist Jan 24, 2025
@patriciareinoso patriciareinoso merged commit 3f6bb50 into main Jan 27, 2025
51 checks passed
@patriciareinoso patriciareinoso deleted the fix-handle-no-dg branch January 27, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants