Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: showcase working uv plugin fix #803

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Feb 4, 2025

  • Have you signed the CLA?

@tigarmo
Copy link
Collaborator

tigarmo commented Feb 4, 2025

@bepri the snap build failed, so the spread tests didn't run

@bepri
Copy link
Contributor Author

bepri commented Feb 4, 2025

@bepri the snap build failed, so the spread tests didn't run

I'm not sure how to fix that. It can't build the snap because pip requires hashes, which git versions can't provide:

 :: Collecting craft-parts@ git+https://github.com/canonical/craft-parts@c834b9f80996d58c80961b73b562bdf5c6e7a669 (from -r uv-requirements.txt (line 130))
:: ERROR: Can't verify hashes for these requirements because we don't have a way to hash version control repositories:
::     craft-parts@ git+https://github.com/canonical/craft-parts@c834b9f80996d58c80961b73b562bdf5c6e7a669 from git+https://github.com/canonical/craft-parts@c834b9f80996d58c80961b73b562bdf5c6e7a669 (from -r uv-requirements.txt (line 130))

@tigarmo
Copy link
Collaborator

tigarmo commented Feb 5, 2025

@bepri the snap build failed, so the spread tests didn't run

I'm not sure how to fix that. It can't build the snap because pip requires hashes, which git versions can't provide:

 :: Collecting craft-parts@ git+https://github.com/canonical/craft-parts@c834b9f80996d58c80961b73b562bdf5c6e7a669 (from -r uv-requirements.txt (line 130))
:: ERROR: Can't verify hashes for these requirements because we don't have a way to hash version control repositories:
::     craft-parts@ git+https://github.com/canonical/craft-parts@c834b9f80996d58c80961b73b562bdf5c6e7a669 from git+https://github.com/canonical/craft-parts@c834b9f80996d58c80961b73b562bdf5c6e7a669 (from -r uv-requirements.txt (line 130))

afaik pip only requires hashes if the requirements file uses them. Can we export with --no-hashes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants