Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_bmc_config parameter to create_machine to skip re-config of BMC #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acormier1
Copy link

@acormier1 acormier1 commented Oct 16, 2023

The create_machine API in Maas supports a skip_bmc_config flag. When set to true, this flag skips the bmc config so that a new user is not created. This is a workaround for some lenovo BMC's which have an issue during this provisioning step.

The result in maas when providing this parameter:
Screen Shot 2023-10-16 at 5 49 22 PM

Copy link
Member

@SK1Y101 SK1Y101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look alright, though the MAAS API docs do suggest this parameter is an integer rather than a boolean https://git.launchpad.net/maas/tree/src/maasserver/api/machines.py#n2039, so we may need to do some testing

This parameter is also passable to the commissioning stage of a Machine, extending to include that may be useful.

@SK1Y101 SK1Y101 force-pushed the add_skip_bmc_config branch from fcfbbd0 to b29f064 Compare March 18, 2024 18:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.43%. Comparing base (bfe63cc) to head (b29f064).

Files Patch % Lines
maas/client/viscera/machines.py 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   69.43%   69.43%   -0.01%     
==========================================
  Files          76       76              
  Lines        6024     6026       +2     
  Branches     1347     1348       +1     
==========================================
+ Hits         4183     4184       +1     
  Misses       1612     1612              
- Partials      229      230       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SK1Y101
Copy link
Member

SK1Y101 commented Mar 19, 2024

Linter isn't happy, could you run tox -e format to fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants