Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using --profile flag to subcommands #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbott
Copy link

@jbott jbott commented Aug 24, 2022

This flag was broken, since it referenced an unset attribute profile on
the parsed options object.

@Yasumoto
Copy link

@sparkiegeek anything we can/should do to help get this tested and (hopefully) merged? 🙏🏼

@sparkiegeek
Copy link
Contributor

Thanks for the contribution, please can you add tests for this?

@SK1Y101
Copy link
Member

SK1Y101 commented Aug 21, 2023

Hey @jbott!
Are you still working on this/willing to work on this?
If so, could you add the requested tests, and we could get this merged? that would be great!

This flag was broken, since it referenced an unset attribute profile on
the parsed options object.
@SK1Y101 SK1Y101 force-pushed the ott-fix-profile-flag branch from 7790423 to 03c1d30 Compare August 21, 2023 07:52
@SK1Y101 SK1Y101 added the bug label Aug 21, 2023
@jbott
Copy link
Author

jbott commented Aug 23, 2023

Sorry, I no longer use MaaS. I think there is still a bug in this patch – running the command without the --profile flag was non-functional if I remember correctly (which I never bothered to fix because I only invoked it via a wrapper script).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants