-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added image creation from public lxd server #378
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Felix Engelmann <[email protected]>
27dfe23
to
0ca5da6
Compare
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 96.26% 96.38% +0.12%
==========================================
Files 12 12
Lines 1044 1051 +7
Branches 121 122 +1
==========================================
+ Hits 1005 1013 +8
+ Misses 17 16 -1
Partials 22 22
Continue to review full report at Codecov.
|
Signed-off-by: Felix Engelmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you also update the documentation to include the new class method?
Signed-off-by: Felix Engelmann <[email protected]>
This is great; unfortunately, I can't merge it yet, as due to an unrelated issue, it won't pass its integration tests. See #379 for more details. When that's sorted, we can rebase this, and then get it merged. |
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 97.21% 96.38% -0.84%
==========================================
Files 55 12 -43
Lines 4027 1051 -2976
Branches 0 122 +122
==========================================
- Hits 3915 1013 -2902
+ Misses 112 16 -96
- Partials 0 22 +22
Continue to review full report at Codecov.
|
Signed-off-by: Felix Engelmann <[email protected]>
There is an option to pull public images from existing lxd instances, similar to simplestream.
Signed-off-by: Felix Engelmann [email protected]