Oracle-bm-timeout-fix #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
force-pushed
the
oracle-bm-timeout-fix
branch
3 times, most recently
from
c8f275a to
499cfae
Compare
|
no idea what is broken with the ci-integration-tests job |
TheRealFalcon
approved these changes
Jan 16, 2025
a-dubs
force-pushed
the
oracle-bm-timeout-fix
branch
2 times, most recently
from
3323e72 to
9856837
Compare
Raising a timeout exception instead of a generic exception allows for consumers of pycloudlib to retry when instance launching fails due to timing out. This is important when trying to launch BM instances which can sometimes fail to provision even when the Oracle API reports their being sufficient capacity.
a-dubs
force-pushed
the
oracle-bm-timeout-fix
branch
2 times, most recently
from
11d5061 to
a24fc02
Compare
Add new class variable `ready_timeout` that can be customizable per cloud. Changed the default to 10m but kept EC2's at 40m. Also, updated the public function instance.wait() to explicitly accept an optional ready_timeout arg. If not given, will use the default value defined for that instance class.
a-dubs
force-pushed
the
oracle-bm-timeout-fix
branch
from
a24fc02 to
b2ea654
Compare
| @@ -15,6 +15,7 @@ class EC2Instance(BaseInstance): | |||
| """EC2 backed instance.""" | |||
|
|
|||
| _type = "ec2" | |||
| ready_timeout = 40 # To keep backwards compatibility (will lower soon) | |||
There was a problem hiding this comment.
Suggested change
| ready_timeout = 40 # To keep backwards compatibility (will lower soon) | |
| ready_timeout = 40 # To keep backwards compatibility (will lower soon™) |
(this is a joke, don't actually apply this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not squash merge, rebase merge to keep the two separate commits please!