Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit:1 in the cos-agent relation #122

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

Abuelodelanada
Copy link
Contributor

Not limiting the amount of relations you can establish through this interface may lead to weird situations.

For more context: https://discourse.charmhub.io/t/one-grafana-agent-charm-to-rule-them-all/16014

Not limiting the amount of relations you can establish through this interface may lead to weird situations.

For more context: https://discourse.charmhub.io/t/one-grafana-agent-charm-to-rule-them-all/16014
Copy link
Member

@gabrielcocenza gabrielcocenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias Jose!

LGTM

Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jneo8
Copy link
Contributor

jneo8 commented Nov 22, 2024

Re-trigger the ci.

@jneo8
Copy link
Contributor

jneo8 commented Nov 22, 2024

/canonical/self-hosted-runners/run-workflows 3b6e557

@jneo8
Copy link
Contributor

jneo8 commented Nov 22, 2024

The CI failed because it don't have permission to access the secrets.

@jneo8 jneo8 merged commit 783f90d into canonical:main Nov 22, 2024
5 of 6 checks passed
@jneo8
Copy link
Contributor

jneo8 commented Nov 22, 2024

CI pass on #123 , merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants