Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE - 6153] - Propagate the security index intitialized through the peercluster relation #517

Merged

Conversation

skourta
Copy link
Contributor

@skourta skourta commented Dec 5, 2024

Fixes #516

Summary

@skourta skourta requested a review from reneradoi December 5, 2024 06:52
Copy link
Contributor

@reneradoi reneradoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @skourta for investigating and bringing up this solution for the issue. I think it is a valid approach and helps to set the security_index_initialized more consistently on the peer-cluster applications.

There are only some minor things that need to be adjusted from my point of view. Good Job!

Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Jan 17, 2025
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Smail, great work!

lib/charms/opensearch/v0/models.py Show resolved Hide resolved
lib/charms/opensearch/v0/opensearch_base_charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@reneradoi reneradoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval after PR had already been reviewed from my-side previously.

@Mehdi-Bendriss Mehdi-Bendriss merged commit 5e61ab8 into 2/edge Jan 17, 2025
31 of 39 checks passed
@Mehdi-Bendriss Mehdi-Bendriss deleted the DPE-6153-open-search-vm-security-index-reinitialized-bug branch January 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security index is reinitialiased by peer cluster which removes the monitor user
3 participants