Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd sync_docs #330

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Readd sync_docs #330

merged 5 commits into from
Jun 26, 2024

Conversation

phvalguima
Copy link
Contributor

@phvalguima phvalguima commented Jun 17, 2024

Adding support to sync docs from discourse to github.

@phvalguima phvalguima requested a review from a-velasco June 17, 2024 05:20
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Jun 17, 2024
@a-velasco
Copy link
Contributor

a-velasco commented Jun 17, 2024

I would recommend keeping this PR paused for now. This workflow will not work right now for two reasons:

  1. A new API key is needed (I'll generate one for all repos when the issue is fixed)
  2. Unrelated to the key, the action is returning unexpected errors. Currently looking into it (DPE-4655)

More context about 2. in this discourse-gatekeeper issue

Copy link
Contributor

@a-velasco a-velasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comments in the .yaml file, one more change is needed: delete the entire /docs folder so that the content can be re-generated with the new version of the workflow.

@phvalguima phvalguima merged commit 13f722c into main Jun 26, 2024
31 checks passed
@phvalguima phvalguima deleted the readd-sync-docs-yaml branch June 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants