Ensure OpenSearch lock is written to all nodes before using #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
juditnovak,
phvalguima and
Mehdi-Bendriss
Mehdi-Bendriss
approved these changes
Apr 29, 2024
phvalguima
approved these changes
Apr 29, 2024
carlcsaposs-canonical
added a commit
that referenced
this pull request
Apr 30, 2024
## Issue Fixes #263 ## Solution Check if lock exists instead of trying to create lock to check if it exists When creating lock, we wait for all shards—which does not happen if a unit is offline after it has acquired the lock (i.e. for restart) This change also requires that we delete the lock if, when we create it, the write doesn't go through on all nodes
carlcsaposs-canonical
added a commit
that referenced
this pull request
May 2, 2024
## Issue Fixes #263 ## Solution Check if lock exists instead of trying to create lock to check if it exists When creating lock, we wait for all shards—which does not happen if a unit is offline after it has acquired the lock (i.e. for restart) This change also requires that we delete the lock if, when we create it, the write doesn't go through on all nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By checking that opensearch lock is replicated to all nodes, we should avoid edge cases where we have 2+ online nodes and then a node has a network cut & only sees 1 online node, doesn't have the lock replicated, and requests the peer databag lock since it thinks no unit has the opensearch lock
Potentially fixesno effect on #243@Mehdi-Bendriss reproduced the issue in #243 and found:
which means the issue should not be related to a failing cluster manager election with 2 -> 1 units
so it's most likely that the lock document was not replicated to unit 0
Context: https://chat.canonical.com/canonical/pl/oc797xcddpn53giu6gtfp4sboo