Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboard opentelemetry-collector #345

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: onboard opentelemetry-collector #345

wants to merge 4 commits into from

Conversation

lucabello
Copy link
Collaborator

Ping the @canonical/rocks team.

Related issues

#333

Picture of a cool rock: 🪨

@lucabello lucabello requested a review from a team as a code owner February 6, 2025 10:33
@lucabello lucabello mentioned this pull request Feb 6, 2025
Open
@zhijie-yang
Copy link
Collaborator

zhijie-yang commented Feb 6, 2025 •
edited
Loading

Hey Luca @lucabello , thanks for the code. However, I have to manually cancel your workflow runs on the Test-Rock workflow, as it's causing an infinite loop there. The root cause is the same as in #342 (review). We are currently updating the oci-factory workflows to make it work (#346).

@zhijie-yang
Copy link
Collaborator

@cjdcordeiro This is a rock with entrypoint-service, which is warned by rockcraft. Should we onboard this as a rock in the OCI Factory? This PR looks good other than this question.

@zhijie-yang zhijie-yang mentioned this pull request Feb 7, 2025
Open
2 tasks
@lucabello
Copy link
Collaborator Author

@zhijie-yang I think we can change the entrypoint for this rock, let me take a look :)

cjdcordeiro
cjdcordeiro requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @zhijie-yang .

@lucabello if you cannot avoid using the entrypoint-service, then we must at least have a very explicit NOTE in the docs, with good usage examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucabello @zhijie-yang @cjdcordeiro