-
Notifications
You must be signed in to change notification settings - Fork 762
[vcpkg] Ditch gRPC port overlay & Update gRPC to 1.71.0 #4621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| index dcdd5a0..8d43c3f 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -497,7 +497,7 @@ if (NOT EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/third_party/xds AND gRPC_DOWNLOAD_ARC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the target to eliminate. Porting this patch to newer releases is a real headache since the patch touches a rather large list of moving parts.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4621 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 250 250
Lines 14276 14276
=======================================
Hits 12511 12511
Misses 1765 1765 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
44d5f01 to
8b13425
Compare
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
tobe2098
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Mustafa, great job! Good to see those red numbers.
|
I notice a significant increase in compilation time: On and on efdd90b: Just from watching the builds, I notice |
Yeah... I was expecting no impact on link times, but it looks like that's not the case. Which os/toolchain/linker is this? The toolchain default? |
This was a standard setup on macOS: Apple clang/default linker I do also have ccache installed, but this wasn't the first time I did a build on this branch. So, ccache won't be totally optimized, but I don't think it should account for the difference in build times that I see here. |
|
My tests (Ubuntu VM -j4): This branch: No caches |
Description
MULTI-2334