make necessary lib changes for k8s #413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
reviewed
May 8, 2024
lib/charms/mongodb/v0/helpers.py
Outdated
|
|
||
| # Increment this PATCH version before using `charmcraft publish-lib` or reset | ||
| # to 0 if you are raising the major API version | ||
| LIBPATCH = 9 |
There was a problem hiding this comment.
> charmcraft fetch-lib charms.mongodb.v0.helpers
Library charms.mongodb.v0.helpers version 0.7 downloaded.
I think the version here should be 8, I think charmhub will complain if you try to skip a version when publishing.
dragomirp
reviewed
May 8, 2024
|
|
||
| # Increment this PATCH version before using `charmcraft publish-lib` or reset | ||
| # to 0 if you are raising the major API version | ||
| LIBPATCH = 8 |
There was a problem hiding this comment.
> charmcraft fetch-lib charms.mongodb.v0.mongodb_backups
Library charms.mongodb.v0.mongodb_backups version 0.6 downloaded.
Like with the other lib, I think charm hub will complain for skipping a version. I guess we can publish manual versions to catch up if it does.
dragomirp
previously approved these changes
May 8, 2024
shayancanonical
previously approved these changes
May 8, 2024
shayancanonical
approved these changes
May 8, 2024
dragomirp
approved these changes
May 8, 2024
Mehdi-Bendriss
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
MongoDB k8s charm does not support backups with current lib implementation
Solution
Easier diff
Diff of changes in last version of lib to new version can be found here
Why are you adding back in the old libapi?
The new LIBAPI introduces a breaking change by supporting sharding, old libs are used my the mongodb k8s charm. So in order to make those changes and publish them we must do so by adding them back to this repo
In the future (24.10) when we support sharding on MongoDB K8s charm we will remove these libs