Clarify aggregate initialization behavior in drmModePropertyRes construction #4618
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] WIP Address feedback on memory management fix
Clarify aggregate initialization behavior in drmModePropertyRes construction
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #4615, #4615 (comment)
What's new?
This PR addresses a review discussion about whether
std::make_unique<drmModePropertyRes>(id)correctly initializes the C struct. The code is correct as-is.Technical clarification:
std::make_unique<T>(args...)uses direct initializationdrmModePropertyRes, passing a single argumentidinitializes the first field (prop_id) with that valuestd::make_unique<drmModePropertyRes>(drmModePropertyRes{id})but more conciseThe construction at line 138 correctly initializes
prop_idto the providedidand zero-initializes all other struct members (flags, name, count_values, etc.).How to test
No code changes - documentation/clarification only.
Checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.