Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimized windows being focused when a focused window is closed #3698

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tarek-y-ismail
Copy link
Contributor

@tarek-y-ismail tarek-y-ismail commented Dec 11, 2024

Closes #3309

TODO:

  • Alt + Tab not working
  • Alt + tabbing between two minimized applications doesn't un-minimize them
    Open three windows, minimize the first two, close the third. Alt + tab between the two minimized windows.
    Expected: Both windows become un-minimized. Reality: Alt tabbing from a window re-minimizes it (or at least hides it)
  • Minimized applications with decorations change their position and size when shown
    This occurred when testing the bug above, when repeatedly alt tabbing between windows (and thus hiding and showing them), I would see that they shifted slightly to the bottom right, with the window size gradually increasing.
  • Following reproduction steps but minimizing the second app, focuses the (minimized) first app
  • Fixing tests

@tarek-y-ismail tarek-y-ismail self-assigned this Dec 11, 2024
Took a moment to rewrite the intersection checking code to use
`std::set_intersection`. Maybe a tad more readable?
@tarek-y-ismail tarek-y-ismail force-pushed the MIRENG-544/closing-window-focuses-minimized-window branch from 0048a5b to fa1e09b Compare December 12, 2024 11:21
@tarek-y-ismail
Copy link
Contributor Author

I think mir_surface and scene_surface are both referring to the same thing?

std::shared_ptr<scene::Surface> const& mir_surface = hint;
if (info_for_hint.state() == mir_window_state_minimized)
{
std::shared_ptr<scene::Surface> const scene_surface{hint};

@tarek-y-ismail tarek-y-ismail force-pushed the MIRENG-544/closing-window-focuses-minimized-window branch from fa1e09b to 478811a Compare December 12, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing a window brings one of the remaining windows of the same client to the front
1 participant