Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debian: drop to -O2 #3691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

debian: drop to -O2 #3691

wants to merge 1 commit into from

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Dec 2, 2024

No description provided.

@Saviq Saviq force-pushed the try-disabling-o3 branch 2 times, most recently from 85808ee to e4bd45e Compare December 2, 2024 16:12
@Saviq Saviq marked this pull request as ready for review December 3, 2024 05:57
@Saviq Saviq requested a review from a team as a code owner December 3, 2024 05:57
@Saviq Saviq requested a review from RAOF December 3, 2024 05:58
@Saviq
Copy link
Collaborator Author

Saviq commented Dec 3, 2024

@RAOF what say you?

This does make things build on plucky again, though a test starts failing.

[ RUN ] Runner.register_fd_handler_after_setup_invokes_callback_when_fd_written_to
[2024-12-02 17:42:21.166201] <information> mirserver: Starting
[2024-12-02 17:42:21.166254] < - debug - > mirserver: No session management supported
[2024-12-02 17:42:21.166285] <information> VT switch key handler: No VT switching support available: MinimalConsoleServices does not support VT switching
[2024-12-02 17:42:21.166386] <information> mircommon: Loading modules from: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/
[2024-12-02 17:42:21.166489] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-eglstream-kms.so.22
[2024-12-02 17:42:21.166514] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-gbm-kms.so.22
[2024-12-02 17:42:21.166532] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/server-x11.so.22
[2024-12-02 17:42:21.166548] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/server-virtual.so.22
[2024-12-02 17:42:21.166563] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-wayland.so.22
[2024-12-02 17:42:21.166577] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/renderer-egl-generic.so.22
[2024-12-02 17:42:21.166591] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-atomic-kms.so.22
[2024-12-02 17:42:21.166604] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/input-evdev.so.10
[2024-12-02 17:42:21.166617] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/input-stub.so
[2024-12-02 17:42:21.167417] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-dummy.so
[2024-12-02 17:42:21.167439] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-throw.so
[2024-12-02 17:42:21.168175] <information> mirserver: Found display driver: mir:stub-graphics (version 2.18.3)
[2024-12-02 17:42:21.168196] <information> mirserver: Driver supports:
[2024-12-02 17:42:21.168207] <information> mirserver: System (priority 1)
[2024-12-02 17:42:21.168219] < -warning- > mirserver: Manually-specified display platform mir:stub-graphics does not claim to support this system. Trying anyway...
[2024-12-02 17:42:21.168665] <information> mirserver: Found display driver: mir:virtual (version 2.18.3)
[2024-12-02 17:42:21.168684] <information> mirserver: (Unsupported by system environment)
[2024-12-02 17:42:21.168702] <information> mirserver: Selected display driver: mir:stub-graphics (version 2.18.3) for platform
[2024-12-02 17:42:21.168761] <information> mircommon: Loading modules from: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/
[2024-12-02 17:42:21.168864] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-eglstream-kms.so.22
[2024-12-02 17:42:21.168890] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-gbm-kms.so.22
[2024-12-02 17:42:21.168908] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/server-x11.so.22
[2024-12-02 17:42:21.168926] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/server-virtual.so.22
[2024-12-02 17:42:21.168943] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-wayland.so.22
[2024-12-02 17:42:21.168960] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/renderer-egl-generic.so.22
[2024-12-02 17:42:21.168976] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-atomic-kms.so.22
[2024-12-02 17:42:21.168991] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/input-evdev.so.10
[2024-12-02 17:42:21.169006] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/input-stub.so
[2024-12-02 17:42:21.170263] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-dummy.so
[2024-12-02 17:42:21.373928] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-throw.so
[2024-12-02 17:42:21.374078] <information> mirserver: Found rendering driver: mir:stub-graphics (version 2.18.3)
[2024-12-02 17:42:21.374104] <information> mirserver: Driver supports:
[2024-12-02 17:42:21.374117] <information> mirserver: System (priority 1)
[2024-12-02 17:42:21.374132] < -warning- > mirserver: Manually-specified rendering platform mir:stub-graphics does not claim to support this system. Trying anyway...
[2024-12-02 17:42:21.374155] <information> mirserver: Selected rendering driver: mir:stub-graphics (version 2.18.3) for platform
[2024-12-02 17:42:21.377830] <information> display: Failed to create hardware cursor
[2024-12-02 17:42:21.377850] <information> mirserver: Using software cursor
[2024-12-02 17:42:21.378563] < - ERROR - > mirserver: Unable to watch directory /usr/local/share//applications
[2024-12-02 17:42:21.378894] <information> mircommon: Loading modules from: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/
[2024-12-02 17:42:21.379000] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-eglstream-kms.so.22
[2024-12-02 17:42:21.379027] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-gbm-kms.so.22
[2024-12-02 17:42:21.379044] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/server-x11.so.22
[2024-12-02 17:42:21.379058] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/server-virtual.so.22
[2024-12-02 17:42:21.379072] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-wayland.so.22
[2024-12-02 17:42:21.379087] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/renderer-egl-generic.so.22
[2024-12-02 17:42:21.379100] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-atomic-kms.so.22
[2024-12-02 17:42:21.379114] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/input-evdev.so.10
[2024-12-02 17:42:21.379126] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/input-stub.so
[2024-12-02 17:42:21.380229] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-dummy.so
[2024-12-02 17:42:21.380259] <information> mircommon: Loading module: /<<PKGBUILDDIR>>/build-amd64/bin/../lib/server-modules/graphics-throw.so
[2024-12-02 17:42:21.380373] <information> mirserver: Selected input driver: mir:stub-input (version: 2.18.3)
[2024-12-02 17:42:21.380521] <information> mirserver: Mir version 2.18.3
[2024-12-02 17:42:21.381225] <information> mirserver: Initial display configuration:
[2024-12-02 17:42:21.381246] <information> mirserver: CTestConfig.cmake CTestTestfile.cmake Testing mir_acceptance_tests.bin.xml mir_acceptance_tests.bin_1.xml mir_acceptance_tests.bin_10.xml mir_acceptance_tests.bin_2.xml mir_acceptance_tests.bin_3.xml mir_acceptance_tests.bin_4.xml mir_acceptance_tests.bin_5.xml mir_acceptance_tests.bin_6.xml mir_acceptance_tests.bin_7.xml mir_acceptance_tests.bin_8.xml mir_acceptance_tests.bin_9.xml mir_umock_acceptance_tests.bin.xml miral-test.bin.xml miral-test.bin_1.xml steer.cmake wlcs.xml wlcs_1.xml wlcs_10.xml wlcs_100.xml wlcs_101.xml wlcs_102.xml wlcs_103.xml wlcs_104.xml wlcs_105.xml wlcs_106.xml wlcs_107.xml wlcs_108.xml wlcs_109.xml wlcs_11.xml wlcs_110.xml wlcs_111.xml wlcs_112.xml wlcs_113.xml wlcs_114.xml wlcs_115.xml wlcs_116.xml wlcs_117.xml wlcs_118.xml wlcs_119.xml wlcs_12.xml wlcs_120.xml wlcs_121.xml wlcs_122.xml wlcs_123.xml wlcs_13.xml wlcs_14.xml wlcs_15.xml wlcs_16.xml wlcs_17.xml wlcs_18.xml wlcs_19.xml wlcs_2.xml wlcs_20.xml wlcs_21.xml wlcs_22.xml wlcs_23.xml wlcs_24.xml wlcs_25.xml wlcs_26.xml wlcs_27.xml wlcs_28.xml wlcs_29.xml wlcs_3.xml wlcs_30.xml wlcs_31.xml wlcs_32.xml wlcs_33.xml wlcs_34.xml wlcs_35.xml wlcs_36.xml wlcs_37.xml wlcs_38.xml wlcs_39.xml wlcs_4.xml wlcs_40.xml wlcs_41.xml wlcs_42.xml wlcs_43.xml wlcs_44.xml wlcs_45.xml wlcs_46.xml wlcs_47.xml wlcs_48.xml wlcs_49.xml wlcs_5.xml wlcs_50.xml wlcs_51.xml wlcs_52.xml wlcs_53.xml wlcs_54.xml wlcs_55.xml wlcs_56.xml wlcs_57.xml wlcs_58.xml wlcs_59.xml wlcs_6.xml wlcs_60.xml wlcs_61.xml wlcs_62.xml wlcs_63.xml wlcs_64.xml wlcs_65.xml wlcs_66.xml wlcs_67.xml wlcs_68.xml wlcs_69.xml wlcs_7.xml wlcs_70.xml wlcs_71.xml wlcs_72.xml wlcs_73.xml wlcs_74.xml wlcs_75.xml wlcs_76.xml wlcs_77.xml wlcs_78.xml wlcs_79.xml wlcs_8.xml wlcs_80.xml wlcs_81.xml wlcs_82.xml wlcs_83.xml wlcs_84.xml wlcs_85.xml wlcs_86.xml wlcs_87.xml wlcs_88.xml wlcs_89.xml wlcs_9.xml wlcs_90.xml wlcs_91.xml wlcs_92.xml wlcs_93.xml wlcs_94.xml wlcs_95.xml wlcs_96.xml wlcs_97.xml wlcs_98.xml wlcs_99.xml Output 1: VGA connected, used
[2024-12-02 17:42:21.381261] <information> mirserver: . |_ Physical size 0.0" 0x0mm
[2024-12-02 17:42:21.381273] <information> mirserver: . |_ Power is on
[2024-12-02 17:42:21.381286] <information> mirserver: . |_ Current mode 1600x1600 60.00Hz
[2024-12-02 17:42:21.381298] <information> mirserver: . |_ Preferred mode 1600x1600 60.00Hz
[2024-12-02 17:42:21.381306] <information> mirserver: . |_ Orientation normal
[2024-12-02 17:42:21.381317] <information> mirserver: . |_ Logical size 1600x1600
[2024-12-02 17:42:21.381328] <information> mirserver: . |_ Logical position +0+0
[2024-12-02 17:42:21.381339] <information> mirserver: . |_ Scaling factor: 1.00
[2024-12-02 17:42:21.381427] < - debug - > miral: Configuring pointer: 'basic-window-manager'
../../../tests/miral/runner.cpp:138: Failure
Value of: signal->wait_for(a_short_time)
Actual: false
Expected: true

[2024-12-02 17:42:21.748257] <information> input-hub: Device configuration: basic-window-manager, capabilities={pointer}
[2024-12-02 17:42:21.748309] <information> mirserver: Stopping
[ FAILED ] Runner.register_fd_handler_after_setup_invokes_callback_when_fd_written_to (592 ms)

@RAOF
Copy link
Contributor

RAOF commented Dec 4, 2024

So, as we've noticed, the default flags are becoming -O3 in plucky, and failures there are probably some sort of bug that we have (or, maybe, is a toolchain bug that should be filed). I don't mind dropping to -O2 temporarily, but we should also work out what's wrong.

@AlanGriffiths
Copy link
Collaborator

I don't mind dropping to -O2 temporarily, but we should also work out what's wrong.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAOF RAOF Awaiting requested review from RAOF

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saviq @RAOF @AlanGriffiths