bugfix: when placing a surface that ignores exclusion zones, the application_zone should be the full display_area #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGriffiths
requested changes
Nov 26, 2024
There was a problem hiding this comment.
The place_new_surface() change is fine (have suggested a readability tweak).
The place_and_size_for_state() is likely harmless but pointless as we're not handling attached windows there. They are handled in modify_window()` which I think covers all the usecases.
src/miral/basic_window_manager.cpp
Outdated
Comment on lines
1376
to
1378
| auto const ignore_exclusion_zones = modifications.ignore_exclusion_zones().is_set() | ||
| ? modifications.ignore_exclusion_zones().value() | ||
| : window_info.ignore_exclusion_zones(); |
There was a problem hiding this comment.
Suggested change
| auto const ignore_exclusion_zones = modifications.ignore_exclusion_zones().is_set() | |
| ? modifications.ignore_exclusion_zones().value() | |
| : window_info.ignore_exclusion_zones(); | |
| auto const ignore_exclusion_zones = modifications.ignore_exclusion_zones().value_or( | |
| window_info.ignore_exclusion_zones()); |
There was a problem hiding this comment.
But I notice that place_and_size_for_state() is not handling attached windows anyway. That isn't trivial to change, as the application zone extents may affected by the windows we may be trying to place. And that is beyond the scope of this function.
src/miral/basic_window_manager.cpp
Outdated
Comment on lines
1885
to
1886
| auto const ignore_exclusion_zones = parameters.ignore_exclusion_zones().is_set() | ||
| && parameters.ignore_exclusion_zones().value(); |
There was a problem hiding this comment.
Suggested change
| auto const ignore_exclusion_zones = parameters.ignore_exclusion_zones().is_set() | |
| && parameters.ignore_exclusion_zones().value(); | |
| auto const ignore_exclusion_zones = parameters.ignore_exclusion_zones().value_or(false); |
…ication_zone should be the full display_area
mattkae
force-pushed
the
bugfix/initial_placement_exclusion
branch
from
5069673 to
2c3d235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the surface ignores exclusion zones, then we should use the display area instead of the application zone
cosmic-bgis now broken always as it should be 🎉